I think it may be Samuel Weir, Apprenticed in 1817, Freedom 1847. Dates do seem a bit odd - a 30 year Apprenticeship? See Dietert "The Edinburg Goldsmiths" page 96.
.
If he continued to work for his master after he had finished his apprenticeship, as a journeyman, he would have no need to apply for his Freedom, (he would still have to pay a fee for the privilege).
I would guess in this case that he did not set up business on his own account, probably until the death or retirement of his master. It would be at this point that he would be required to obtain his Freedom.